pch/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
picoclaw/pkg/tools
History
程智超0668000959 b86ab71836 fix(tools): allow scheme-less URLs in workspace guard 
The workspace guard's absolutePathPattern regex matches /Beijing?T in commands like 'curl wttr.in/Beijing'. Since 'wttr.in' is not a recognized web scheme, the path was routed through workspace sandbox validation, which could block legitimate scheme-less URL usage (curl allows bare domains without http://).

Add detection for domain-like tokens preceding /path matches:
- looksLikeDomain: checks for dot-separated tokens that don't end with common file extensions (.py, .go, .exe, etc.)
- localPathExists: verifies the token does not exist as a local filesystem entry

This dual guard prevents the symlink bypass identified in PR #2965 review: if 'foo.bar' exists as a local symlink or directory, the path still undergoes full workspace validation.

Fixes #1042.
2026-06-04 19:59:49 +08:00
..
fs fix test 2026-05-12 23:23:26 +02:00
hardware fix(serial_windows): remove unused import (#2697) 2026-04-28 16:19:59 +08:00
integration fix(message): gate local media attachments 2026-05-22 16:36:44 -07:00
shared fix(tools) limit edit diff preview size for user and model 2026-05-12 23:12:37 +02:00
cron.go refactor(cron): flatten if-else chains and suppress dupl lint 2026-06-01 20:08:40 +08:00
cron_test.go feat(cron): restrict list/get/update to accessible jobs per channel 2026-05-31 19:20:41 +08:00
delegate.go fix(tools): normalize agent_id before self-check and delegation 2026-04-15 22:23:17 +08:00
delegate_test.go test(tools): verify normalization prevents self-delegation bypass 2026-04-15 22:23:47 +08:00
facade_compat_test.go feat(tools): add cross-platform serial hardware tool 2026-04-28 12:54:28 +08:00
fs_facade.go fix(providers,tools): address linter issues after reorg 2026-04-17 14:16:18 +08:00
fs_registry_compat_test.go refactor(tools): reorganize tool packages and facades 2026-04-17 13:44:31 +08:00
hardware_facade.go feat(tools): add cross-platform serial hardware tool 2026-04-28 12:54:28 +08:00
identifier_compat.go refactor(tools): reorganize tool packages and facades 2026-04-17 13:44:31 +08:00
integration_facade.go feat(providers): add gemini web search provider (#2763) 2026-05-14 09:50:47 +08:00
load_image_compat_test.go refactor(tools): reorganize tool packages and facades 2026-04-17 13:44:31 +08:00
normalization.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00
path_compat.go refactor(tools): reorganize tool packages and facades 2026-04-17 13:44:31 +08:00
registry.go fix(tools): exempt MCP discovery tools from agent allowlists 2026-05-08 09:18:14 +02:00
registry_test.go fix(tools): exempt MCP discovery tools from agent allowlists 2026-05-08 09:18:14 +02:00
result_test.go fix(tools) limit edit diff preview size for user and model 2026-05-12 23:12:37 +02:00
search_tool.go fix(tools): exempt MCP discovery tools from agent allowlists 2026-05-08 09:18:14 +02:00
search_tools_test.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00
session.go fix(tools): use sync.Once for thread-safe Stop() in SessionManager 2026-06-02 20:20:30 +08:00
session_process_unix.go feat(tools): add exec tool enhancement with background execution and PTY support (#1752) 2026-03-25 21:02:49 +08:00
session_process_windows.go feat(tools): add exec tool enhancement with background execution and PTY support (#1752) 2026-03-25 21:02:49 +08:00
session_test.go fix(tools): add Stop() to SessionManager to prevent goroutine leak 2026-06-02 17:13:31 +08:00
shared_facade.go feat(tools): show unified diff for edit_file edits 2026-05-12 18:06:47 +02:00
shell.go fix(tools): allow scheme-less URLs in workspace guard 2026-06-04 19:59:49 +08:00
shell_process_unix.go fix(exec): terminate process tree on timeout 2026-02-18 02:01:29 +08:00
shell_process_windows.go fix(exec): terminate process tree on timeout 2026-02-18 02:01:29 +08:00
shell_test.go fix(tools): use sync.Once for thread-safe Stop() in SessionManager 2026-06-02 20:20:30 +08:00
shell_timeout_unix_test.go feat(tools): add exec tool enhancement with background execution and PTY support (#1752) 2026-03-25 21:02:49 +08:00
spawn.go Merge upstream/main into feat/agent-discovery-prompt 2026-05-07 13:16:30 +02:00
spawn_status.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00
spawn_status_test.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00
spawn_test.go Merge upstream/main into feat/agent-discovery-prompt 2026-05-07 13:16:30 +02:00
subagent.go feat(agent): add TargetAgentID to SubTurnConfig for cross-agent delegation 2026-04-15 21:27:13 +08:00
subagent_tool_test.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00
sysproc_unix.go feat(tools): add exec tool enhancement with background execution and PTY support (#1752) 2026-03-25 21:02:49 +08:00
sysproc_windows.go feat(tools): add exec tool enhancement with background execution and PTY support (#1752) 2026-03-25 21:02:49 +08:00
toolloop.go feat: add load_image tool for local file vision (#2116) 2026-04-01 21:32:10 +08:00
validate.go feat(tools): add tool argument schema validation before execution (#1877) 2026-03-24 18:35:56 +08:00
validate_test.go chore: revert unrelated golines formatting 2026-03-29 14:06:19 +02:00