pch/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3023 from chengzhichao-xydt/codex/updater-close-errors

Browse source 
fix: check Close() errors in updater extraction functions
This commit is contained in:
Mauro 2026-06-06 16:12:41 +02:00 committed by GitHub
commit ebf17aa152
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/updater/updater.go
View file

@ -584,8 +584,13 @@ func extractZip(archivePath, destDir string) error {
out.Close() out.Close()
return err return err
} }
rc.Close() if err := rc.Close(); err != nil {
out.Close() out.Close()
return fmt.Errorf("close zip entry reader: %w", err)
}
if err := out.Close(); err != nil {
return fmt.Errorf("close extracted file %q: %w", target, err)
}
} }
return nil return nil
} }
@ -649,7 +654,9 @@ func extractTarFromReader(tr *tar.Reader, destDir string) error {
out.Close() out.Close()
return err return err
} }
out.Close() if err := out.Close(); err != nil {
return fmt.Errorf("close extracted file %q: %w", target, err)
}
} }
} }
return nil return nil