Merge pull request #3022 from chengzhichao-xydt/codex/sync-map-assertions

fix: add ok checks for sync.Map LoadAndDelete/Load type assertions
This commit is contained in:
Mauro 2026-06-06 16:20:28 +02:00 committed by GitHub
commit c19e4e8db1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 4 deletions

View file

@ -746,8 +746,8 @@ func (c *FeishuChannel) isBotMentioned(message *larkim.EventMessage) bool {
return false
}
knownID, _ := c.botOpenID.Load().(string)
if knownID == "" {
knownID, ok := c.botOpenID.Load().(string)
if !ok || knownID == "" {
logger.DebugCF("feishu", "Bot open_id unknown, cannot detect @mention", nil)
return false
}

View file

@ -154,7 +154,10 @@ func (c *SlackChannel) Send(ctx context.Context, msg bus.OutboundMessage) ([]str
}
if ref, ok := c.pendingAcks.LoadAndDelete(deliveryChatID); ok {
msgRef := ref.(slackMessageRef)
msgRef, ok := ref.(slackMessageRef)
if !ok {
return []string{ts}, nil
}
c.api.AddReaction("white_check_mark", slack.ItemRef{
Channel: msgRef.ChannelID,
Timestamp: msgRef.Timestamp,

View file

@ -62,7 +62,10 @@ func postStartPlatformIsolation(cmd *exec.Cmd, isolation config.IsolationConfig,
if !isolation.Enabled || cmd == nil || cmd.Process == nil {
return nil
}
resourcesAny, _ := windowsPendingResources.LoadAndDelete(cmd)
resourcesAny, loaded := windowsPendingResources.LoadAndDelete(cmd)
if !loaded {
return nil
}
resources, _ := resourcesAny.(windowsProcessResources)
// Job objects can only be attached after the process exists, so the Windows
// backend finishes isolation in this post-start hook.