pch/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3189 from chengzhichao-xydt/codex/line-body-close

Browse source 
fix(line): explicitly ignore resp.Body.Close() errors in Send and classifySDKError
This commit is contained in:
Mauro 2026-07-05 09:35:40 +02:00 committed by GitHub
commit b6e6d25d75
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/channels/line/line.go
View file

@ -69,7 +69,8 @@ func NewLINEChannel(
return nil, fmt.Errorf("failed to create LINE messaging client: %w", err) return nil, fmt.Errorf("failed to create LINE messaging client: %w", err)
} }
base := channels.NewBaseChannel("line", cfg, messageBus, bc.AllowFrom, base := channels.NewBaseChannel(
"line", cfg, messageBus, bc.AllowFrom,
channels.WithMaxMessageLength(5000), channels.WithMaxMessageLength(5000),
channels.WithGroupTrigger(bc.GroupTrigger), channels.WithGroupTrigger(bc.GroupTrigger),
channels.WithReasoningChannelID(bc.ReasoningChannelID), channels.WithReasoningChannelID(bc.ReasoningChannelID),
@ -482,7 +483,7 @@ func (c *LINEChannel) Send(ctx context.Context, msg bus.OutboundMessage) ([]stri
Messages: []messaging_api.MessageInterface{&textMsg}, Messages: []messaging_api.MessageInterface{&textMsg},
}) })
if resp != nil && resp.Body != nil { if resp != nil && resp.Body != nil {
resp.Body.Close() _ = resp.Body.Close()
} }
if err == nil { if err == nil {
logger.DebugCF("line", "Message sent via Reply API", map[string]any{ logger.DebugCF("line", "Message sent via Reply API", map[string]any{
@ -588,7 +589,7 @@ func (c *LINEChannel) StartTyping(ctx context.Context, chatID string) (func(), e
// classifySDKError maps an SDK HTTP response to the project's sentinel errors. // classifySDKError maps an SDK HTTP response to the project's sentinel errors.
func classifySDKError(resp *http.Response, err error) error { func classifySDKError(resp *http.Response, err error) error {
if resp != nil && resp.Body != nil { if resp != nil && resp.Body != nil {
resp.Body.Close() _ = resp.Body.Close()
} }
if err == nil { if err == nil {
return nil return nil