pch/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3033 from chengzhichao-xydt/codex/media-close-errors

Browse source 
fix: check Close() error after downloading media file
This commit is contained in:
Mauro 2026-06-07 14:00:34 +02:00 committed by GitHub
commit 7c18fe8421
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/utils/media.go
View file

@ -146,7 +146,6 @@ func DownloadFile(urlStr, filename string, opts DownloadOptions) string {
})
return ""
}
defer out.Close()
if _, err := io.Copy(out, resp.Body); err != nil {
out.Close()
@ -156,6 +155,13 @@ func DownloadFile(urlStr, filename string, opts DownloadOptions) string {
})
return ""
}
if err := out.Close(); err != nil {
logger.ErrorCF(opts.LoggerPrefix, "Failed to close downloaded file", map[string]any{
"error": err.Error(),
})
os.Remove(localPath)
return ""
}
logger.DebugCF(opts.LoggerPrefix, "File downloaded successfully", map[string]any{
"path": localPath,