pch/picoclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3170 from chengzhichao-xydt/codex/base64-encoder-close-clean

Browse source 
fix(agent): close base64 encoder on io.Copy error path
This commit is contained in:
Mauro 2026-06-26 08:40:58 +02:00 committed by GitHub
commit 5feeb91c60
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/agent/agent_media.go
View file

@ -172,14 +172,22 @@ func encodeImageToDataURL(localPath, mime string, info os.FileInfo, maxSize int)
buf.WriteString(prefix) buf.WriteString(prefix)
encoder := base64.NewEncoder(base64.StdEncoding, &buf) encoder := base64.NewEncoder(base64.StdEncoding, &buf)
if _, err := io.Copy(encoder, f); err != nil { _, copyErr := io.Copy(encoder, f)
closeErr := encoder.Close()
if copyErr != nil {
logger.WarnCF("agent", "Failed to encode media file", map[string]any{ logger.WarnCF("agent", "Failed to encode media file", map[string]any{
"path": localPath, "path": localPath,
"error": err.Error(), "error": copyErr.Error(),
})
return ""
}
if closeErr != nil {
logger.WarnCF("agent", "Failed to close base64 encoder", map[string]any{
"path": localPath,
"error": closeErr.Error(),
}) })
return "" return ""
} }
encoder.Close()
return buf.String() return buf.String()
} }